Data extensions editor: Remove buttons that are no longer needed#2635
Merged
shati-patel merged 1 commit intomainfrom Jul 25, 2023
Merged
Data extensions editor: Remove buttons that are no longer needed#2635shati-patel merged 1 commit intomainfrom
shati-patel merged 1 commit intomainfrom
Conversation
shati-patel
commented
Jul 25, 2023
| </VSCodeButton> | ||
| </> | ||
| {viewState.mode === Mode.Framework && ( | ||
| <VSCodeButton onClick={onGenerateFromSourceClick}> |
Contributor
Author
There was a problem hiding this comment.
I've just removed Application mode from the conditional. Should we also remove the references to Application mode from the underlying function here, or are we expecting to use that somewhere else? 🤔
Contributor
Author
There was a problem hiding this comment.
Actually, ignore me! It looks like this function is also called from the "Model from source" button in application mode, so will keep it as-is:
Contributor
There was a problem hiding this comment.
Yep, that's right. That code is still called in both modes.
robertbrignull
approved these changes
Jul 25, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM and tested locally too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes/renames some buttons. See internal issue for more details!
✌🏽 Application mode:
😎 Framework mode:
Checklist
N/A: feature-flagged for internal use ⛳
ready-for-doc-reviewlabel there.